src/lib/features/chatbot/view/widgets/user_avatar.dart-40-45 (1)

40-45: ⚠️ Potential issue | 🟡 Minor

URL validation rejects legitimate URLs without a path.

uri.hasAbsolutePath is true only when the URI's path starts with /. For https://cdn.example.com (no trailing slash), path is empty and hasAbsolutePath is false, so this helper classifies it as invalid even though it's a perfectly valid HTTP(S) URL. Validate scheme + authority instead:

🐛 Suggested fix

   bool _isValidHttpUrl(String value) {
     if (value.isEmpty || value.length > 2048) return false;
     final uri = Uri.tryParse(value);
     if (uri == null) return false;
-    return uri.hasAbsolutePath && (uri.scheme == 'http' || uri.scheme == 'https');
+    return uri.hasAuthority && (uri.scheme == 'http' || uri.scheme == 'https');
   }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/lib/features/chatbot/view/widgets/user_avatar.dart` around lines 40 - 45,
The _isValidHttpUrl helper wrongly rejects valid host-only URLs by requiring
uri.hasAbsolutePath; change the validation to check that the parsed Uri has a
valid HTTP/HTTPS scheme and a non-empty authority/host instead. Keep the
existing empty and max-length checks, use Uri.tryParse(value) as before, then
require (uri.scheme == 'http' || uri.scheme == 'https') and (uri.hasAuthority or
uri.host.isNotEmpty) so URLs like "https://cdn.example.com" are accepted.

src/lib/features/user/view/widgets/stat_card.dart-17-23 (1)

17-23: ⚠️ Potential issue | 🟡 Minor

Fix tap affordance and deprecated API usage.

• Line 17: onTap: onTap ?? () {} makes the card always show ripple effects even when no callback is supplied. Use onTap: onTap instead to allow null and prevent misleading tap affordance when the card is purely informational.
• Line 23: Color.withOpacity is deprecated in Flutter 3.27+; use .withValues(alpha: 0.5) instead.

♻️ Suggested changes

       child: InkWell(
-        onTap: onTap ?? () {}, // Interactive ripple effect
+        onTap: onTap,
         borderRadius: BorderRadius.circular(24),
         child: Container(
           padding: const EdgeInsets.symmetric(vertical: 24),
           decoration: BoxDecoration(
             borderRadius: BorderRadius.circular(24),
-            border: Border.all(color: Theme.of(context).colorScheme.outline.withOpacity(0.5)),
+            border: Border.all(
+              color: Theme.of(context).colorScheme.outline.withValues(alpha: 0.5),
+            ),
           ),

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/lib/features/user/view/widgets/stat_card.dart` around lines 17 - 23, The
StatCard widget currently forces a ripple by using onTap: onTap ?? () {}, so
remove the fallback and set onTap: onTap to allow null (no ripple) when no
handler is provided; also replace the deprecated
Theme.of(context).colorScheme.outline.withOpacity(0.5) call with the 3.27+ API
using .withValues(alpha: 0.5) when constructing the Border.all color to avoid
deprecated usage.

src/lib/features/chatbot/model/chatmessage_model.dart-14-23 (1)

14-23: ⚠️ Potential issue | 🟡 Minor

isUser defaults to true on missing/invalid JSON — can silently mislabel bot messages.

In fromJson, json['isUser'] as bool? ?? true will coerce any persisted message lacking the isUser field (or with a non-bool value) into a user message. If storage is ever corrupted, migrated, or written by an older version, bot replies will be rendered as user bubbles and re-sent back to Gemini as user context, degrading the conversation. Defaulting to false (or, better, dropping the entry when the field is absent) is safer.

🛡️ Proposed fix

-      isUser: json['isUser'] as bool? ?? true,
+      isUser: json['isUser'] is bool ? json['isUser'] as bool : false,

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/lib/features/chatbot/model/chatmessage_model.dart` around lines 14 - 23,
The fromJson factory for ChatMessageModel currently coerces missing/invalid
json['isUser'] to true, which can mislabel bot messages; update
ChatMessageModel.fromJson to treat json['isUser'] safely by validating its type
and defaulting to false (or omitting the field) when absent/invalid: check
whether json['isUser'] is a bool (or parseable) and only use it when valid,
otherwise set isUser: false to avoid accidentally marking bot replies as user
messages.

src/lib/features/auth/otp_verification_view.dart-160-165 (1)

160-165: ⚠️ Potential issue | 🟡 Minor

Resend success snackbar uses tertiary — check dark-mode legibility.

In the dark theme, colorScheme.tertiary is #D19900 (mustard yellow). Default SnackBar content is white, which has weak contrast against mustard. Consider a success color (e.g., a dedicated green) or set an explicit contentTextStyle for readability. Also nit: "OTP code resent!" — consider "OTP resent" (OTP already contains "code").

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/lib/features/auth/otp_verification_view.dart` around lines 160 - 165, The
SnackBar shown by ScaffoldMessenger.of(context).showSnackBar uses
colorScheme.tertiary which is low-contrast in dark mode; change the SnackBar to
use an accessible success color (e.g., Colors.green or a theme success color) or
set an explicit contentTextStyle with a high-contrast color, and also update the
message string from "OTP code resent!" to the shorter "OTP resent"; locate the
SnackBar construction (the SnackBar(...) block) and replace the
backgroundColor/text style and message accordingly.

src/lib/features/auth/otp_verification_view.dart-136-147 (1)

136-147: ⚠️ Potential issue | 🟡 Minor

Use colorScheme.onPrimary for content sitting on the primary button, not surface.

The ElevatedButton background is colorScheme.primary, so the spinner color and the "CONFIRM" label should be colorScheme.onPrimary. Using surface happens to look white in light mode (because surface is white), but in dark mode surface is #1E293B (dark slate) rendered on top of the bright-blue primary (#60A5FA) — that yields a hard-to-see dark spinner and dark label on a blue button.

🎨 Proposed fix

       child: _vm.isLoading
-          ? CircularProgressIndicator(
-        color: Theme.of(context).colorScheme.surface,
-      )
+          ? CircularProgressIndicator(
+        color: Theme.of(context).colorScheme.onPrimary,
+      )
           : Text(
         'CONFIRM',
         style: TextStyle(
           fontSize: 16,
           fontWeight: FontWeight.bold,
-          color: Theme.of(context).colorScheme.surface,
+          color: Theme.of(context).colorScheme.onPrimary,
         ),
       ),

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/lib/features/auth/otp_verification_view.dart` around lines 136 - 147, The
spinner and label on the ElevatedButton use
Theme.of(context).colorScheme.surface but should use colorScheme.onPrimary when
rendered on a primary-colored button; update the
CircularProgressIndicator(color: ...) and the Text style color in
otp_verification_view.dart (the branch that checks _vm.isLoading and the Text
'CONFIRM') to use Theme.of(context).colorScheme.onPrimary instead of .surface so
content remains legible on the primary background.

src/lib/features/user/service/user_service.dart-10-24 (1)

10-24: ⚠️ Potential issue | 🟡 Minor

Double-wrapped exception message and unsafe cast of the RPC response.

Two small issues worth cleaning up here:

1. The blanket catch(e) { throw Exception("Failed to fetch user profile: $e"); } also catches the Exception(...) you just threw on Lines 13 and 17, producing nested messages like Exception: Failed to fetch user profile: Exception: Không tìm thấy phiên đăng nhập... that then surface in the UI fallback path in user_profile_viewmodel.dart. Either rethrow your own exceptions untouched or only wrap the Supabase call.
2. response from _supabase.rpc(...) is typed as dynamic. response['id'] = ... on Line 19 will throw at runtime if the RPC ever returns a non-Map payload (e.g., a List or primitive). Cast/guard explicitly, and reuse the already-nullchecked user.id instead of currentUser!.id.

♻️ Suggested cleanup

-  Future<UserProfileModel> fetchUserProfile() async {
-    // Mimic API call delay for smooth state switching
-    try{
-      final user = _supabase.auth.currentUser;
-      if (user == null) {
-        throw Exception("Không tìm thấy phiên đăng nhập. Hãy đăng nhập lại");
-      }
-      final response = await _supabase.rpc('get_user_profile_stats');
-      if(response == null){
-        throw Exception("Không thể lấy thông tin người dùng. Hãy thử lại sau");
-      }
-      response['id'] = _supabase.auth.currentUser!.id;
-      return UserProfileModel.fromJson(response);
-    }
-    catch(e){
-      throw Exception("Failed to fetch user profile: $e");
-    }
-  }
+  Future<UserProfileModel> fetchUserProfile() async {
+    final user = _supabase.auth.currentUser;
+    if (user == null) {
+      throw Exception("Không tìm thấy phiên đăng nhập. Hãy đăng nhập lại");
+    }
+    try {
+      final response = await _supabase.rpc('get_user_profile_stats');
+      if (response is! Map) {
+        throw Exception("Không thể lấy thông tin người dùng. Hãy thử lại sau");
+      }
+      final json = Map<String, dynamic>.from(response as Map);
+      json['id'] = user.id;
+      return UserProfileModel.fromJson(json);
+    } on PostgrestException catch (e) {
+      throw Exception("Failed to fetch user profile: ${e.message}");
+    }
+  }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/lib/features/user/service/user_service.dart` around lines 10 - 24, The
current try/catch in the user profile fetch double-wraps thrown Exceptions and
unsafely assumes the RPC result is a Map; update the logic in the method that
calls _supabase.rpc('get_user_profile_stats') so you: 1) obtain and null-check
final user = _supabase.auth.currentUser and reuse user.id (avoid currentUser!);
2) call the RPC inside a try/catch that only wraps the RPC call (or rethrow
non-RPC exceptions) so your own thrown Exceptions are not caught and re-wrapped;
and 3) explicitly validate/cast the RPC response to Map<String, dynamic> (or
throw a clear Exception if it’s not a Map) before assigning response['id'] and
passing it to UserProfileModel.fromJson to avoid unsafe casts.

src/lib/features/user/view/user_profile_view.dart-144-148 (1)

144-148: ⚠️ Potential issue | 🟡 Minor

Appearance toggle collapses any non-Dark value to Light.

If user.appearance is 'System' (or any unexpected value), the first tap flips it to 'Dark' then toggles Light/Dark forever, losing the system option. If System is a supported mode, cycle through all three; otherwise at least normalize it.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/lib/features/user/view/user_profile_view.dart` around lines 144 - 148,
The current onTap handler passes vm.updateAppearance(context, user.appearance ==
'Dark' ? 'Light' : 'Dark'), which collapses any non-'Dark' value (e.g.,
'System') to 'Light' and loses the system option; change the logic in the onTap
(or inside vm.updateAppearance) to handle three-state cycling: if
user.appearance == 'Dark' -> set 'Light', else if user.appearance == 'Light' ->
set 'System' (or 'Dark' depending on desired cycle), else if user.appearance ==
'System' -> set 'Dark'; alternatively, normalize unknown values to a supported
default before toggling. Reference vm.updateAppearance and user.appearance to
locate and update the toggle logic accordingly.

src/lib/features/main/view/screens/main_screen.dart-27-43 (1)

27-43: ⚠️ Potential issue | 🟡 Minor

SettingsScreen at index 5 is unreachable.

The bottom nav only has 5 items (indices 0–4), so _screens[5] (SettingsScreen) can never be shown and the widget is instantiated on every build for nothing. Either drop it, or add a way to navigate there (e.g. from the profile “settings” IconButton on line 38, which currently has an empty onPressed).

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/lib/features/main/view/screens/main_screen.dart` around lines 27 - 43,
The SettingsScreen entry in the _screens list is unreachable because the
BottomNavigationBar only exposes five tabs; either remove the unreachable const
SettingsScreen from the _screens list, or wire up navigation to it: for example,
remove SettingsScreen from _screens and implement the UserProfileView settings
IconButton's onPressed to navigate
(Navigator.of(context).push(MaterialPageRoute(builder: (_) => const
SettingsScreen()))), or alternatively add a sixth BottomNavigationBarItem and
update the selectedIndex handling to include SettingsScreen; update the _screens
list consistently (and stop instantiating SettingsScreen on every build if you
opt for push navigation).

src/lib/core/theme/theme_provider.dart-8-14 (1)

8-14: ⚠️ Potential issue | 🟡 Minor

Guard the async preference load from overwriting newer theme changes.

_loadThemeFromPrefs() starts in the constructor and can complete after updateTheme(), resetting _themeMode back to stale persisted data. Track a generation/token or await initialization before accepting updates.

🛡️ Proposed guard

 class ThemeProvider extends ChangeNotifier {
 
   static const String _themeKey = "theme_mode";
 
-  ThemeMode _themeMode = ThemeMode.light;
+  ThemeMode _themeMode = ThemeMode.system;
+  int _themeGeneration = 0;
@@
   void updateTheme(String appearance) {
+    _themeGeneration++;
     final normalized = appearance.trim().toLowerCase();
@@
   Future<void> _loadThemeFromPrefs() async {
+    final generation = _themeGeneration;
     final prefs = await SharedPreferences.getInstance();
     final appearance = (prefs.getString(_themeKey) ?? 'Light').trim().toLowerCase();
+
+    if (generation != _themeGeneration) return;
 
     if (appearance == 'dark') {
       _themeMode = ThemeMode.dark;

Also applies to: 17-35, 44-55

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/lib/core/theme/theme_provider.dart` around lines 8 - 14, The async prefs
load in ThemeProvider can race with user-triggered updateTheme and overwrite
newer state; modify ThemeProvider to guard against stale writes by adding a
version/token (e.g., _loadVersion or _initToken) that is captured when
_loadThemeFromPrefs starts and compared before applying its result, or expose a
Future/Completer (e.g., initializationComplete) and have updateTheme await
initialization; ensure _loadThemeFromPrefs, the constructor kick-off, and
updateTheme all reference the same token/ready flag so the async load only sets
_themeMode if its token matches the latest or initialization hasn't completed.

supabase/migrations/20260418111957_chatbot_add_task_with_category_rpc.sql-58-62 (1)

58-62: ⚠️ Potential issue | 🟡 Minor

Avoid returning raw database errors to the client.

SQLERRM can expose table names, constraint names, or internal details; this value is also fed back into the chatbot flow. Log the detailed error server-side and return a generic failure message.

Suggested safer response

 EXCEPTION WHEN OTHERS THEN
   RETURN json_build_object(
     'success', false,
-    'error', SQLERRM
+    'error', 'Không thể tạo task. Vui lòng thử lại.'
   );

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@supabase/migrations/20260418111957_chatbot_add_task_with_category_rpc.sql`
around lines 58 - 62, The EXCEPTION WHEN OTHERS block currently returns raw
SQLERRM to the client via json_build_object which can leak internal DB details;
change it to log the detailed error server-side (for example use RAISE LOG
'chatbot_add_task error: %', SQLERRM or insert into an internal error table) and
return a generic failure payload instead (e.g. json_build_object('success',
false, 'error', 'An internal error occurred')). Update the EXCEPTION WHEN OTHERS
section to stop returning SQLERRM directly and instead RAISE LOG or otherwise
persist SQLERRM for server-side debugging while returning the generic message to
the caller.

src/lib/features/chatbot/view/widgets/message_composer.dart-37-63 (1)

37-63: ⚠️ Potential issue | 🟡 Minor

Disable or implement the no-op composer actions.

The add and mic buttons look interactive but do nothing. Disable them until the attachment/voice flows exist, or wire them to real callbacks.

Suggested fix until the features are implemented

             IconButton(
               constraints: const BoxConstraints.tightFor(width: 40, height: 40),
               padding: EdgeInsets.zero,
-              onPressed: () {},
+              onPressed: null,
               icon: Icon(Icons.add_circle, color: scheme.onSurfaceVariant),
             ),
...
             IconButton(
               constraints: const BoxConstraints.tightFor(width: 40, height: 40),
               padding: EdgeInsets.zero,
-              onPressed: () {},
+              onPressed: null,
               icon: Icon(Icons.mic, color: scheme.onSurfaceVariant),
             ),

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/lib/features/chatbot/view/widgets/message_composer.dart` around lines 37
- 63, The add and mic IconButton widgets in message_composer.dart are currently
no-ops (onPressed: () {}); either disable them by setting onPressed to null (so
they render disabled) or wire them to real callbacks by adding/using props like
onAttach and onRecord and calling those (respecting isSending state), e.g.,
replace the no-op onPressed for the Icons.add_circle and Icons.mic with null
when the feature is unimplemented or with calls to the new onAttach/onRecord
handlers so the buttons are functional and testable.

src/lib/features/chatbot/view/chatbot_view.dart-91-104 (1)

91-104: ⚠️ Potential issue | 🟡 Minor

Don’t label persisted chat history as “Today” unconditionally.

ChatBotViewModel persists timestamped messages, so messages restored tomorrow or later will still appear under the “Today” separator. Either group by message.timestamp or remove the static separator until date grouping is implemented.

Quick fix: remove the misleading static separator

-                    itemCount: viewModel.messages.length + 1,
+                    itemCount: viewModel.messages.length,
                     itemBuilder: (context, index) {
-                      if (index == 0) {
-                        return const Padding(
-                          padding: EdgeInsets.only(bottom: 16),
-                          child: DaySeparator(label: 'Today'),
-                        );
-                      }
-
-                      final message = viewModel.messages[index - 1];
+                      final message = viewModel.messages[index];
                       return MessageTile(
                         message: message,
                         userAvatarUrl: widget.userAvatarUrl,
                       );

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/lib/features/chatbot/view/chatbot_view.dart` around lines 91 - 104, The
static "Today" DaySeparator should be removed because persisted messages are
timestamped and may not all be from today; update the builder in
chatbot_view.dart by deleting the index==0 branch that returns DaySeparator and
change itemCount from viewModel.messages.length + 1 to
viewModel.messages.length, then adjust message lookup to use
viewModel.messages[index] (keeping MessageTile and widget.userAvatarUrl
unchanged); alternatively implement proper date grouping later using
message.timestamp (referencing DaySeparator, viewModel.messages, MessageTile,
and ChatBotViewModel).

src/lib/features/chatbot/viewmodel/chatbot_viewmodel.dart-83-88 (1)

83-88: ⚠️ Potential issue | 🟡 Minor

Guard against notifyListeners() on disposed notifier.

The sendMessage() method calls notifyListeners() at line 88 after awaiting _aiService.sendMessage(). If the chat screen is dismissed during this await, the method can continue executing and call notifyListeners() on a disposed ChangeNotifier, causing an error.

Additionally, _loadHistory() has the same vulnerability at line 56 when calling notifyListeners() after the async SharedPreferences.getInstance() call.

Add a _disposed flag and guard both methods:

Suggested implementation

 class ChatBotViewModel extends ChangeNotifier {
   static const String _historyKey = 'chatbot_history_v1';
   static const int _maxHistoryMessages = 200;
+
+  bool _disposed = false;
 
   final _aiService = ChatBotAssistantService();
   final List<ChatMessageModel> _messages = [];
 
   ChatBotViewModel() {
     _loadHistory();
   }
+
+  `@override`
+  void dispose() {
+    _disposed = true;
+    super.dispose();
+  }
+
+  void _notifyIfActive() {
+    if (!_disposed) notifyListeners();
+  }
 
   List<ChatMessageModel> _initialMessages() => [
     ChatMessageModel(
       text: 'Chào bạn! Tôi là trợ lý năng suất. Hôm nay bạn cần tôi giúp gì?',
       isUser: false,
     ),
   ];
 
   List<ChatMessageModel> get messages => _messages;
 
   bool _isLoading = false;
 
   bool get isLoading => _isLoading;
 
   Future<void> _loadHistory() async {
     try {
       final prefs = await SharedPreferences.getInstance();
+      if (_disposed) return;
       final raw = prefs.getString(_historyKey);
 
       if (raw == null || raw.trim().isEmpty) {
         _messages
           ..clear()
           ..addAll(_initialMessages());
         await _saveHistory();
       } else {
         final storedMessages = ChatMessageModel.decodeList(raw);
         _messages
           ..clear()
           ..addAll(
             storedMessages.isEmpty ? _initialMessages() : storedMessages,
           );
       }
     } catch (e) {
       debugPrint('Error loading chatbot history: $e');
       _messages
         ..clear()
         ..addAll(_initialMessages());
     }
 
-    notifyListeners();
+    _notifyIfActive();
   }
 
   Future<void> sendMessage(String text) async {
     final normalizedText = text.trim();
     if (normalizedText.isEmpty) return;
 
     _messages.add(ChatMessageModel(text: normalizedText, isUser: true));
     _isLoading = true;
     notifyListeners();
     await _saveHistory();
 
     final response = await _aiService.sendMessage(normalizedText);
+    if (_disposed) return;
 
     _messages.add(ChatMessageModel(text: response, isUser: false));
     _isLoading = false;
     await _saveHistory();
-    notifyListeners();
+    _notifyIfActive();
   }
 }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/lib/features/chatbot/viewmodel/chatbot_viewmodel.dart` around lines 83 -
88, Add a private boolean _disposed flag to the ChatbotViewModel, set it to true
in the dispose() override, and guard state mutations and notifyListeners() in
both sendMessage() and _loadHistory(): after each await (e.g. await
_aiService.sendMessage(...) in sendMessage() and await
SharedPreferences.getInstance() in _loadHistory()) check if (_disposed) return
before updating _messages, _isLoading, calling _saveHistory(), or calling
notifyListeners(); ensure all early exits prevent touching the disposed
notifier.

src/lib/features/user/model/user_profile_model.dart-30-40 (1)

30-40: ⚠️ Potential issue | 🟡 Minor

Harden the heatmapData cast against Map<dynamic, dynamic>.

final Map<String, dynamic> rawHeatmap = json['heatmapData']; relies on the incoming value being strictly Map<String, dynamic>. Nested JSON decoded via different paths (or a Supabase RPC returning jsonb through an alternate channel) can yield Map<dynamic, dynamic>, which will throw a TypeError on this implicit cast before any of the try/catch in the forEach can run. Normalize defensively:

🛡️ Proposed fix

-    Map<DateTime, int> parseHeatmap = {};
-    if (json['heatmapData'] != null) {
-      final Map<String, dynamic> rawHeatmap = json['heatmapData'];
-      rawHeatmap.forEach((dateString, count) {
+    Map<DateTime, int> parseHeatmap = {};
+    final rawHeatmapValue = json['heatmapData'];
+    if (rawHeatmapValue is Map) {
+      final rawHeatmap = Map<String, dynamic>.from(rawHeatmapValue);
+      rawHeatmap.forEach((dateString, count) {
         try {
           parseHeatmap[DateTime.parse(dateString)] = parseInt(count);
         } catch (e) {
           // skip error
         }
       });
     }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/lib/features/user/model/user_profile_model.dart` around lines 30 - 40,
The code assumes json['heatmapData'] is Map<String,dynamic> which can throw a
TypeError for Map<dynamic,dynamic>; instead, defensively handle it by treating
json['heatmapData'] as a generic Map (e.g., var raw = json['heatmapData']; if
(raw is Map) iterate raw.entries, convert each entry.key.toString() to parse
DateTime and coerce the value to int with your existing parseInt logic),
preserving the existing try/catch around DateTime/parseInt and populating
parseHeatmap. Update references to rawHeatmap and parseHeatmap accordingly so no
implicit cast to Map<String,dynamic> occurs.